forbidden-apis: Don't need java.solr.txt file #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
commented
Nov 16, 2024
| @@ -99,7 +99,6 @@ allprojects { prj -> | |||
| "**.SuppressForbidden" | |||
| ] | |||
|
|
|||
| doFirst dynamicSignatures.curry(configurations.toolsCompileClasspath, "lucene") | |||
There was a problem hiding this comment.
I don't quite understand this line but the reference to "lucene" probably matches nothing.
| @@ -113,18 +112,6 @@ allprojects { prj -> | |||
| ] | |||
| } | |||
|
|
|||
| // Configure solr-specific rules. | |||
There was a problem hiding this comment.
the whole configuration overall is for Solr
| // Configure solr-specific rules. | ||
| if (prj.path.startsWith(":solr")) { | ||
| forbiddenApisMain { | ||
| doFirst dynamicSignatures.curry(configurations.compileClasspath, "solr") |
There was a problem hiding this comment.
Maybe I should have kept this line? I'm not sure what it accomplishes.
| } | ||
|
|
||
| forbiddenApisTest { | ||
| doFirst dynamicSignatures.curry(configurations.testCompileClasspath, "solr") |
There was a problem hiding this comment.
Maybe I should have kept this line? I'm not sure what it accomplishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through our forbidden-apis configuration, and I see "java.solr.txt" file that appears named this way because it was added at a time when Lucene & Solr co-existed and needed to be differentiated. I moved the rules from there into "defaults.all.txt", and I removed the reference to this file in forbidden-apis.gradle.
But I see other stuff in forbidden-apis.gradle that I don't understand; it's a rather complicated gradle file IMO. Hoping for your review @dweiss as you wrote this one.