Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmokeTestRelease Added support for multiple JDK #2685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iamsanjay
Copy link
Contributor

This PR removes the hardcoded reference to Java and introduces support for multiple JDK versions through the new --test-alt-java parameter. This enhancement was largely inspired by the work in Apache Lucene PR #13108.

Credits to the contributors of the original implementation for their valuable insights.

@iamsanjay iamsanjay changed the title Added support for multiple JDK SmokeTestRelease Added support for multiple JDK Aug 30, 2024
@iamsanjay
Copy link
Contributor Author

Though I have yet to test with the different version. I mostly ran it with the same version, and on mac.

python3 -u ./dev-tools/scripts/smokeTestRelease.py   --test-alt-java /Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home  file:///tmp/releases/10.0.0/solr-10.0.0-RC1-rev-fed9db04b5b16ae829d9c7bfb19b972ade0f0bdc

Copy link

This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Oct 30, 2024
Copy link

This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again.

@github-actions github-actions bot added the closed-stale Closed after being stale for 60 days label Dec 29, 2024
@github-actions github-actions bot closed this Dec 29, 2024
Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks useful, let's get it in!

@janhoy janhoy reopened this Jan 3, 2025
@janhoy
Copy link
Contributor

janhoy commented Jan 3, 2025

@iamsanjay Can you also update the description of the tool in README.md in the scripts folder?

@janhoy janhoy removed stale PR not updated in 60 days closed-stale Closed after being stale for 60 days labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants