-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SmokeTestRelease Added support for multiple JDK #2685
base: main
Are you sure you want to change the base?
Conversation
Though I have yet to test with the different version. I mostly ran it with the same version, and on mac.
|
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks useful, let's get it in!
@iamsanjay Can you also update the description of the tool in |
This PR removes the hardcoded reference to Java and introduces support for multiple JDK versions through the new
--test-alt-java
parameter. This enhancement was largely inspired by the work in Apache Lucene PR #13108.Credits to the contributors of the original implementation for their valuable insights.