Allow manually rebuild docker images #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Sep 6, 2024
| @@ -20,6 +20,7 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Don't we need a version parameter to manually build?
There was a problem hiding this comment.
Don't we need a version parameter to manually build?
No. We would either rebuild the latest master branch or need code changes in latest master. Rebuilding an old commit doesn't make sense.
There was a problem hiding this comment.
I see. You want to rebuild the latest for local branch? Is that the purpose?
There was a problem hiding this comment.
So, this would not work for fork repo, mostly it is for committers' branch.
wu-sheng
approved these changes
Sep 6, 2024
|
We should consider upgrade the Istio version in the tests, 1.7 ~ 1.9 looks really outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.