Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ClassPathURLLoader cannot find files under GraalVM Native Image #30145

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Feb 16, 2024

For #30139.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian changed the title Fixes ClassPathURLLoader cannot find files under GraalVM Native Image Fixes ClassPathURLLoader cannot find files under GraalVM Native Image and JAR Feb 16, 2024
@linghengqian linghengqian changed the title Fixes ClassPathURLLoader cannot find files under GraalVM Native Image and JAR Fixes ClassPathURLLoader cannot find files under GraalVM Native Image Feb 16, 2024
@zhaojinchao95 zhaojinchao95 added this to the 5.5.0 milestone Feb 16, 2024
@linghengqian linghengqian force-pushed the fix-classpath-test branch 2 times, most recently from ddea6f3 to 14911d2 Compare February 17, 2024 04:16
Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graalvm is too special, could it be separate with normal logic and put them into a concentrated graalvm module?

@linghengqian linghengqian force-pushed the fix-classpath-test branch 2 times, most recently from 7c6b40a to cba4dad Compare February 17, 2024 06:16
@linghengqian
Copy link
Member Author

linghengqian commented Feb 17, 2024

graalvm is too special, could it be separate with normal logic and put them into a concentrated graalvm module?

@terrymanu

@terrymanu
Copy link
Member

graalvm is too special, could it be separate with normal logic and put them into a concentrated graalvm module?

@terrymanu

Use InputStream is a good idea

@linghengqian linghengqian force-pushed the fix-classpath-test branch 3 times, most recently from 4213283 to 19a4582 Compare February 17, 2024 08:07
@linghengqian
Copy link
Member Author

Use InputStream is a good idea

  • Done.

Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @terrymanu Is there anything holding back the current PR from being merged? As shardingsphere refactor further, the number of JSON entries that need to be modified to fix nativeTest increases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants