Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly CI for NativeTest under GraalVM CE #29540

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Dec 25, 2023

For https://github.com/apache/shardingsphere/actions/runs/7316101526/job/19930405436 .

Changes proposed in this pull request:

  • Fix nightly CI for NativeTest under GraalVM CE. Refer to https://github.com/apache/shardingsphere/actions/runs/7316101526/job/19930405436 . On low-performance devices in Github Actions, INSERT related SQLs may throw a table not found error under nativeTest. So that we need to wait for a period of time after executing CREATE TABLE related SQLs before executing INSERT related SQLs. This may mean that the implementation of org.apache.shardingsphere.mode.repository.cluster.zookeeper.ZookeeperRepository needs optimization.
  • Add a Github Actions file to specifically check nativeTest. Considering that not every Contributor uses GraalVM CE, this Job should not be placed in ci.yml to avoid Contributor not knowing how to repair the corresponding CI through GraalVM CE.
  • Use regular expressions to simplify configuration of resource-config.json. .*META-INF/services/org\.apache\.shardingsphere\..+ may conflict with the JSON entry for shardingsphere-elasticjob in the future. But this does not affect before GraalVM CE for JDK 29.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian force-pushed the fix-nativetest branch 18 times, most recently from 6766877 to 6f1aff0 Compare December 27, 2023 12:08
@linghengqian linghengqian marked this pull request as ready for review December 27, 2023 14:24
@tristaZero tristaZero merged commit e63c517 into apache:master Dec 27, 2023
134 checks passed
@linghengqian linghengqian deleted the fix-nativetest branch December 27, 2023 14:46
@linghengqian linghengqian added this to the 5.4.2 milestone Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants