Add elasticjob-lite-reachability-metadata module for nativeTest and nativeRun
#2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
force-pushed
the
add-new-module
branch
from
472b229
to
cfbaa9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2263 +/- ##
============================================
+ Coverage 84.40% 84.41% +0.01%
Complexity 1926 1926
============================================
Files 287 287
Lines 6341 6341
Branches 704 704
============================================
+ Hits 5352 5353 +1
+ Misses 662 661 -1
Partials 327 327
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
linghengqian
force-pushed
the
add-new-module
branch
from
cfbaa9d
to
77af251
Compare
…date Curator to match GraalVM Reachability Metadata. Update Zookeeper to avoid ZOOKEEPER-4460
linghengqian
force-pushed
the
add-new-module
branch
2 times, most recently
from
315fb7e
to
746e5fe
Compare
linghengqian
force-pushed
the
add-new-module
branch
from
746e5fe
to
9ff6e5d
Compare
linghengqian
commented
Sep 15, 2023
There was a problem hiding this comment.
- @TeslaCN Can you give some review feedback? Should these JSON files be concentrated on specific submodules like this, or is it better to be scattered across the actual submodules?
linghengqian
commented
Sep 16, 2023
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2258.
Changes proposed in this pull request:
Add
elasticjob-lite-reachability-metadatamodule for nativeTest and nativeRun. We obviously need to adopt unmerged Metadata faster than GraalVM Reachability Metadata's central repository.Update Curator to match GraalVM Reachability Metadata. Refer to
org.apache.curator:curator-client:5.5.0oracle/graalvm-reachability-metadata#381org.apache.curator:curator-framework:5.5.0oracle/graalvm-reachability-metadata#383Update Zookeeper to avoid ZOOKEEPER-4460 . Refer to Add support for
org.apache.curator:curator-*:5.4.0oracle/graalvm-reachability-metadata#163 (comment) .Add relevant documentation.