Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove offline server ip #2251

Merged
merged 3 commits into from
Sep 4, 2023
Merged

remove offline server ip #2251

merged 3 commits into from
Sep 4, 2023

Conversation

songxiaosheng
Copy link
Member

@songxiaosheng songxiaosheng commented Sep 1, 2023

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • support remove offline serverIp logic

@songxiaosheng
Copy link
Member Author

@TeslaCN PATL

@TeslaCN
Copy link
Member

TeslaCN commented Sep 1, 2023

Could we add an option for this? Sometimes we may set server disable in non-container environment.

@songxiaosheng
Copy link
Member Author

Could we add an option for this? Sometimes we may set server disable in non-container environment.

This is compatible, no stateful nodes are removed, and the existing state does not remove the recommended hosting state.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023

Codecov Report

Attention: Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.52%. Comparing base (9afe466) to head (8f557e9).
Report is 195 commits behind head on master.

Files with missing lines Patch % Lines
...elasticjob/lite/internal/server/ServerService.java 40.90% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2251      +/-   ##
============================================
- Coverage     84.69%   84.52%   -0.17%     
- Complexity     1927     1931       +4     
============================================
  Files           287      287              
  Lines          6317     6340      +23     
  Branches        700      704       +4     
============================================
+ Hits           5350     5359       +9     
- Misses          646      658      +12     
- Partials        321      323       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TeslaCN TeslaCN merged commit 73f420e into apache:master Sep 4, 2023
9 checks passed
@TeslaCN TeslaCN added this to the 3.0.4 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants