Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timeout job #1923

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sunkai-cai
Copy link
Contributor

Fixes #1464

Changes proposed in this pull request:

  • add timeout of JobConfiguration
  • support timeout for ElasticJobExecutor

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #1923 (9427640) into master (adcf88c) will decrease coverage by 0.01%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1923      +/-   ##
============================================
- Coverage     85.66%   85.64%   -0.02%     
  Complexity      114      114              
============================================
  Files           276      276              
  Lines          6026     6048      +22     
  Branches        922      925       +3     
============================================
+ Hits           5162     5180      +18     
- Misses          525      528       +3     
- Partials        339      340       +1     
Impacted Files Coverage Δ
...sphere/elasticjob/executor/ElasticJobExecutor.java 87.73% <76.19%> (-3.57%) ⬇️
...hardingsphere/elasticjob/api/JobConfiguration.java 74.50% <100.00%> (+1.04%) ⬆️
...re/elasticjob/infra/pojo/JobConfigurationPOJO.java 100.00% <100.00%> (ø)
.../namespace/job/parser/JobBeanDefinitionParser.java 100.00% <100.00%> (ø)
...rdingsphere/elasticjob/infra/json/GsonFactory.java 100.00% <0.00%> (ø)
...ticjob/lite/internal/snapshot/SnapshotService.java 82.53% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcf88c...9427640. Read the comment docs.

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Not sure if I'm asking too late. Should this PR add documentation?

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I rebase the relevant branch, but it seems that some unit tests timeout.

@sunkai-cai
Copy link
Contributor Author

Maybe this is not a good design。 We need redesign it if we need the timeout features。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest to support timeout for JobConfiguration
4 participants