-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support timeout job #1923
base: master
Are you sure you want to change the base?
Support timeout job #1923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
============================================
- Coverage 85.66% 85.64% -0.02%
Complexity 114 114
============================================
Files 276 276
Lines 6026 6048 +22
Branches 922 925 +3
============================================
+ Hits 5162 5180 +18
- Misses 525 528 +3
- Partials 339 340 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Not sure if I'm asking too late. Should this PR add documentation?
9427640
to
a69e297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I rebase the relevant branch, but it seems that some unit tests timeout.
Maybe this is not a good design。 We need redesign it if we need the timeout features。 |
Fixes #1464
Changes proposed in this pull request: