Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-348] Implement ST_MakePoint #950

Merged
merged 15 commits into from
Aug 11, 2023
Merged

Conversation

yyy1000
Copy link
Contributor

@yyy1000 yyy1000 commented Aug 8, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Add ST_MakePoint to sedona-common, sedona-sql, sedona-flink, and the dataframe/python API.

How was this patch tested?

  1. Comprehensive unit tests in sedona-common
  2. Integration unit tests in sedona-sql, sedona-flink, and python.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@jiayuasu
Copy link
Member

jiayuasu commented Aug 9, 2023

@yyy1000 Please fix this PR using the solution provided by #952

@yyy1000
Copy link
Contributor Author

yyy1000 commented Aug 9, 2023

@yyy1000 Please fix this PR using the solution provided by #952

Got it. Fixed it already.

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add documentation.

:type z: ColumnOrNameOrNumber
:param z: Either a number or numeric column representing the measure of a point, if None then a 3D point is generated without measure, defaults to None
:type z: ColumnOrNameOrNumber
:return: Point geometry column generated from the coordinate values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to include param m?

@jiayuasu
Copy link
Member

@yyy1000 Are you planning to implement ST_MakePointM?

@jiayuasu jiayuasu merged commit 3999f2e into apache:master Aug 11, 2023
39 checks passed
@jiayuasu jiayuasu deleted the makePoint branch August 11, 2023 07:40
@yyy1000
Copy link
Contributor Author

yyy1000 commented Aug 11, 2023

@yyy1000 Are you planning to implement ST_MakePointM?

I can implement it next week. :)

Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants