Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add pre-commit hook check-docstring-first #1604

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jbampton
Copy link
Member

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-docstring-first

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

Adds another check/test to our pre-commit framework.

How was this patch tested?

Ran locally:

pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jiayuasu jiayuasu merged commit d93f81c into apache:master Sep 25, 2024
4 checks passed
@jbampton jbampton deleted the add-hook-check-docstring-first branch October 8, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants