Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-646] Shapefile DataSource for DataFrame API #1553

Merged
merged 17 commits into from
Aug 23, 2024

Conversation

Kontinuation
Copy link
Member

@Kontinuation Kontinuation commented Aug 19, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

This PR implements a data source for reading shapefiles. Now we don't have to read shapefiles using the RDD API and convert the SpatialRDD to a DataFrame using the adapter. Instead we can simply say:

df = sedona.read.format("shapefile").load("/path/to/shapefile")

to load the shapefile as a DataFrame.

How was this patch tested?

Added new tests.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation.

@Kontinuation Kontinuation changed the title Shapefile DataSource for DataFrame API [SEDONA-646] Shapefile DataSource for DataFrame API Aug 22, 2024
@github-actions github-actions bot added the docs label Aug 22, 2024
@Kontinuation Kontinuation marked this pull request as ready for review August 22, 2024 17:19
@jiayuasu jiayuasu added this to the sedona-1.7.0 milestone Aug 23, 2024
@jiayuasu jiayuasu merged commit 25fc222 into apache:master Aug 23, 2024
50 checks passed
@jiayuasu jiayuasu linked an issue Aug 24, 2024 that may be closed by this pull request
Kontinuation added a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
* Shapefile DataSource for Spark SQL API

* Fix compilation for scala 2.13

* Add tests for the new shapefile reader

* Support reading shape keys

* Add new test files

* Add tests for reading shapefiles with bad shx, and .shp files containing null geometries

* Move shapefile data source to non-spark package name, don't use package private methods

* Add python tests

* Backport to Spark 3.0

* Backport to Spark 3.1

* Backport to Spark 3.2

* Backport to Spark 3.3

* Backport to Spark 3.4

* Fix profile activation for Spark 3.2, spotless apply

* Make the shapefile reader work without GeoTools

* Update documentation

* Change charset handling and add documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShapefileReader with Unity Catalogue on Databricks
2 participants