[SEDONA-635] Allow ST_AsGeoJSON to return feature and featureCollection format GeoJSON #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sedona-python
docs
sedona-flink
sedona-common
sedona-spark
sedona-snowflake
labels
|
@prantogg please open a PR on https://github.com/wherobots/sedona-snowflake-tester to test snowflake implementation. |
jiayuasu
requested changes
Jul 29, 2024
| throw new IllegalArgumentException( | ||
| "Unknown type: " | ||
| + type | ||
| + ". Valid types are: 'geometry', 'feature', 'featurecollection'."); |
There was a problem hiding this comment.
Shouldn't this be simple instead of geometry?
| Format: `ST_AsGeoJSON (A: Geometry)` | ||
| The type parameter (Since: `v1.6.1`) takes the following options - | ||
|
|
||
| - "Simple" (default): Returns a simple GeoJSON geometry. |
There was a problem hiding this comment.
Can you add an example below for the Feature and FeatureCollection
|
@prantogg please fix failed Python tests |
jiayuasu
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
typeparameter to specify format of GeoJSON output.How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.