Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-622] Improve SedonaPyDeck behavior #1515

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

furqaankhan
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • Add type error if a user provides a non-numeric column to
    create_choropleth_map's plot_col parameter.
  • Add a stroked parameter to let the user decide if they want their polygons/points to have a border.

How was this patch tested?

  • Passed existing tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation.

@jiayuasu jiayuasu added this to the sedona-1.6.1 milestone Jul 9, 2024
@jiayuasu jiayuasu merged commit 9c3c67d into apache:master Jul 9, 2024
28 checks passed
@furqaankhan furqaankhan deleted the sedona-pydeck-fix branch July 16, 2024 01:40
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
* feat: throw an error when column is not numeric and add stroked parameter

* fix: tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants