Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【ISSUE #73】support mounting a configMap to rocketmq-dashboard #132

Closed
wants to merge 5 commits into from

Conversation

shendongsd
Copy link

@shendongsd shendongsd commented Oct 10, 2022

What is the purpose of the change

【ISSUE #73】 support mounting a configMap to rocketmq-dashboard

@caigy caigy added this to the 0.4.0 milestone Oct 12, 2022
Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #73, mounting ${rocketmq.config.dataPath}/role-permission.yml should also be supported.

Comment on lines 21 to 22
namesrvAddrs:
- XXX:XXX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO nameserver address should be injected by rocketmq-operator, not manually configured.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shendongsd Should we also define role-permission.yml in config map?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role-permission.yml can be added to configmap

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shendongsd Pls also add role-permission.yml to config map and reference it in Console CR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,I could add it later

@zongtanghu
Copy link

Hi,please fix and optimize the codes according to other member's advices! @shendongsd

@zongtanghu
Copy link

zongtanghu commented Oct 17, 2022

Please, put forward your commit codes for optimizing codes as soon as possible! @shendongsd

Comment on lines +6 to +35
application.yml: |
server:
port: 8080
servlet:
encoding:
charset: UTF-8
enabled: true
force: true
spring:
application:
name: rocketmq-dashboard
logging:
config: classpath:logback.xml
rocketmq:
config:
isVIPChannel:
timeoutMillis:
dataPath: /tmp/rocketmq-console/data
enableDashBoardCollect: true
msgTrackTopicName:
ticketKey: ticket
loginRequired: false
useTLS: false
threadpool:
config:
coreSize: 10
maxSize: 10
keepAliveTime: 3000
queueSize: 5000
role-permission.yml: |+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that indentation is wrong.

@drivebyer
Copy link
Contributor

This pr is not respond for a longtime, so I open another pr to implement it, see: #181

@caigy
Copy link
Contributor

caigy commented Sep 25, 2023

integrated in #182

@caigy caigy closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants