-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【ISSUE #73】support mounting a configMap to rocketmq-dashboard #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #73, mounting ${rocketmq.config.dataPath}/role-permission.yml
should also be supported.
namesrvAddrs: | ||
- XXX:XXX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO nameserver address should be injected by rocketmq-operator, not manually configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shendongsd Should we also define role-permission.yml
in config map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The role-permission.yml can be added to configmap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shendongsd Pls also add role-permission.yml
to config map and reference it in Console
CR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok,I could add it later
Hi,please fix and optimize the codes according to other member's advices! @shendongsd |
Please, put forward your commit codes for optimizing codes as soon as possible! @shendongsd |
application.yml: | | ||
server: | ||
port: 8080 | ||
servlet: | ||
encoding: | ||
charset: UTF-8 | ||
enabled: true | ||
force: true | ||
spring: | ||
application: | ||
name: rocketmq-dashboard | ||
logging: | ||
config: classpath:logback.xml | ||
rocketmq: | ||
config: | ||
isVIPChannel: | ||
timeoutMillis: | ||
dataPath: /tmp/rocketmq-console/data | ||
enableDashBoardCollect: true | ||
msgTrackTopicName: | ||
ticketKey: ticket | ||
loginRequired: false | ||
useTLS: false | ||
threadpool: | ||
config: | ||
coreSize: 10 | ||
maxSize: 10 | ||
keepAliveTime: 3000 | ||
queueSize: 5000 | ||
role-permission.yml: |+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that indentation is wrong.
This pr is not respond for a longtime, so I open another pr to implement it, see: #181 |
integrated in #182 |
What is the purpose of the change
【ISSUE #73】 support mounting a configMap to rocketmq-dashboard