Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #119] Fix MetricsCollectTask cycle dependence #120

Closed
wants to merge 1 commit into from
Closed

[ISSUE #119] Fix MetricsCollectTask cycle dependence #120

wants to merge 1 commit into from

Conversation

humkum
Copy link
Contributor

@humkum humkum commented Nov 18, 2022

fixes #119

maixiaohai
maixiaohai reviewed Jan 8, 2023
View reviewed changes
Copy link
Contributor

@maixiaohai maixiaohai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, your key change is springboot version upgrade.
First thing first, why should we upgrade to version 2.6.6?

@humkum
Copy link
Contributor Author

humkum commented Jan 10, 2023 •
edited
Loading

Because the version of spring boot 2.1.2.RELEASE's dependency jackson-databind is 2.9.8, which is less than version 2.9.10.8, there are multiple security vulnerabilities. See details in FasterXML/jackson-databind#3003
image

@maixiaohai
Copy link
Contributor

Update jackson version is ok，not the springboot version unless you have complete tests.

@humkum humkum closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maixiaohai maixiaohai maixiaohai left review comments

Assignees

@humkum humkum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MetricsCollectTask.class has dependency cycle
2 participants
@humkum @maixiaohai