Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #383]support failed task after connector restart #386

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sunheyi6
Copy link

@sunheyi6 sunheyi6 commented Dec 3, 2022

What is the purpose of the change

close #383
support failed task after connector restart

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@odbozhou
Copy link
Contributor

odbozhou commented Dec 6, 2022

please fix compile error

@odbozhou odbozhou added the enhancement New feature or request label Dec 6, 2022
@sunheyi6
Copy link
Author

sunheyi6 commented Dec 6, 2022

please fix compile error

@odbozhou ok,already fixed. Isn't there some tool that automatically recognizes this formatting problem?

@odbozhou
Copy link
Contributor

odbozhou commented Dec 7, 2022

please fix compile error

@odbozhou ok,already fixed. Isn't there some tool that automatically recognizes this formatting problem?

https://rocketmq.apache.org/zh/docs/4.x/contributionGuide/30code-guidelines

You can refer to this document, ide import checkstyle

Copy link
Contributor

@odbozhou odbozhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.apache.rocketmq.connect.runtime.service.ConfigManagementServiceImpl.ConfigChangeCallback#onCompletion

Is it missing the processing of restart connector and task in ConfigChangeCallback#onCompletion?

@sunheyi6
Copy link
Author

sunheyi6 commented Dec 7, 2022

Is it missing the processing of restart connector and task in ConfigChangeCallback#onCompletion?

@odbozhou I have fixed the problem you mentioned, but how to stop the task, I still don't understand

@odbozhou
Copy link
Contributor

odbozhou commented Dec 8, 2022

Is it missing the processing of restart connector and task in ConfigChangeCallback#onCompletion?

@odbozhou I have fixed the problem you mentioned, but how to stop the task, I still don't understand

org.apache.rocketmq.connect.runtime.connectorwrapper.Worker#awaitStopTask

The worker has provided related methods to wait for the stop task

MemoryConfigManagementServiceImpl#restartTask
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support failed task after connector restart
2 participants