-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #383]support failed task after connector restart #386
base: master
Are you sure you want to change the base?
Conversation
please fix compile error |
@odbozhou ok,already fixed. Isn't there some tool that automatically recognizes this formatting problem? |
https://rocketmq.apache.org/zh/docs/4.x/contributionGuide/30code-guidelines You can refer to this document, ide import checkstyle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org.apache.rocketmq.connect.runtime.service.ConfigManagementServiceImpl.ConfigChangeCallback#onCompletion
Is it missing the processing of restart connector and task in ConfigChangeCallback#onCompletion?
.../src/main/java/org/apache/rocketmq/connect/runtime/controller/AbstractConnectController.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/rocketmq/connect/runtime/controller/AbstractConnectController.java
Outdated
Show resolved
Hide resolved
...ntime/src/main/java/org/apache/rocketmq/connect/runtime/service/ConfigManagementService.java
Outdated
Show resolved
Hide resolved
...ntime/src/main/java/org/apache/rocketmq/connect/runtime/service/ConfigManagementService.java
Outdated
Show resolved
Hide resolved
@odbozhou I have fixed the problem you mentioned, but how to stop the task, I still don't understand |
org.apache.rocketmq.connect.runtime.connectorwrapper.Worker#awaitStopTask The worker has provided related methods to wait for the stop task |
...va/org/apache/rocketmq/connect/runtime/service/memory/MemoryConfigManagementServiceImpl.java
Show resolved
Hide resolved
.../org/apache/rocketmq/connect/runtime/controller/distributed/TestConfigManagementService.java
Show resolved
Hide resolved
MemoryConfigManagementServiceImpl#restartTask
What is the purpose of the change
close #383
support failed task after connector restart
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.