Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1314. Add JaCoCo coverity tests to Github actions #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

softgitron
Copy link
Contributor

@softgitron softgitron commented Feb 14, 2021

What changes were proposed in this pull request?

Add support for JaCoCo coverity analysis, run analysis during CI and upload results to SonarCloud for easy viewing.

In the current version coveirityy is calculated only on the master branch and due to unknown issues does not work with every unit test.

(This is based on @adoroszlai #419 and #422 to reduce conflicts and take advantage of other recent Sonar analysis advancements)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1314

How was this patch tested?

This patch has been manually tested. Preliminary results can be seen from the following links:
https://github.com/softgitron/incubator-ratis/actions/runs/566463295
https://sonarcloud.io/dashboard?id=softgitron_incubator-ratis

@softgitron softgitron force-pushed the RATIS-1314 branch 6 times, most recently from a067be9 to 1004402 Compare April 17, 2021 13:39
@softgitron softgitron marked this pull request as ready for review April 17, 2021 17:15
@softgitron
Copy link
Contributor Author

Comments related to this change are also now welcome! I think the change itself is useful, but I'm not sure is the execution good enough for a merge.

@softgitron
Copy link
Contributor Author

PR rebased to most recent master and commits squashed.

Restrict only to master and alway return 0

Revert delete temporary artifacts move

Change exit 0 to Actions specific option
@softgitron softgitron changed the title Ratis 1314. Add JaCoCo coverity tests to Github actions RATIS-1314. Add JaCoCo coverity tests to Github actions May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant