RATIS-2151. TestRaftWithGrpc keeps failing with zero-copy. #1164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RATIS-2151
This is to fix the following problems described in #1156
3.
GrpcClientProtocolService.UnorderedRequestStreamObserver.processClientRequest(..)
should use try-finally.4.
GrpcLogAppender.appendLog(..)
callsrelease()
incorrectly for exception.6.
LogSegment
cache can release an entry multiple times.7.
LogSegment.loadCache(..)
should callretain()
for cache hit.8.
SegmentedRaftLog.retainLog(..)
: between getting the entry and callingretain()
, the entry can be released. The "fail to retain" exception, if there is any, can be ignored since It is the same as a cache miss. See #11539.
SegmentedRaftLog.retainEntryWithData(..)
should release for exception.10. Test bug: the log entries stored in
SimpleStateMachine4Testing
can be released.11.
LogSegment
: New entries can be added after EntryCache is closed.13.
SegmentedRaftLogWorker
should clean up unfinished tasks in the queue after stopped running.