RATIS-2199. Release once on exception

apache · Nov 25, 2024 · 8e6a331 · 8e6a331
1 parent 04396ca
commit 8e6a331
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java b/ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java
@@ -476,13 +476,17 @@ private void readImpl(DataStreamRequestByteBuf request, ChannelHandlerContext ct
           }
           return null;
         }, requestExecutor)).whenComplete((v, exception) -> {
+      boolean released = false;
       try {
         if (exception != null) {
           replyDataStreamException(server, exception, info.getRequest(), request, ctx);
           removeDataStream(key, info);
+          released = true;
         }
       } finally {
-        request.release();
+        if (!released) {
+          request.release();
+        }
         channels.remove(channelId, key);
       }
     });