[fix][broker] Revert the async modification cause broker lost bookie's rack information in the PR#22846

[TakaHiR07]

Main Issue: #23282

Motivation

Related to #22846 and #22853.

I guess there is a modification in previous pr cause broker lost bookie rack information permanently. The analysis process can see the issue.

Modifications

revert the change.

Verifying this change

• Make sure that the change passes the CI checks.

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

Closing this PR since #23331 replaces this.

[TakaHiR07]

Closing this PR since #23331 replaces this.

@lhotari This pr can not be closed. Because #23331 is not a replaced one, that pr can not fix this issue's error.

[lhotari]

Closing this PR since #23331 replaces this.

@lhotari This pr can not be closed. Because #23331 is not a replaced one, that pr can not fix this issue's error.

@TakaHiR07 ok, I'll reopen this. However we cannot simply revert since there's another issue of deadlocks that appears if that is done. Please start the dev mailing list discussion (as discussed in #23330 (comment)) since this problem is a release blocker.

[TakaHiR07]

@TakaHiR07 ok, I'll reopen this. However we cannot simply revert since there's another issue of deadlocks that appears if that is done. Please start the dev mailing list discussion (as discussed in #23330 (comment)) since this problem is a release blocker.

I have noticed the deadlock issue before and I am not sure why fix deadlock should make BookieRackAffinityMapping#watchAvailableBookies become async. I guess we just need this pr, then can fix the deadlock, #22853