Skip to content

Commit

Permalink
[fix][ml] Remove unnecessary return in ManagedLedgerImpl
Browse files Browse the repository at this point in the history
  • Loading branch information
summeriiii committed Oct 8, 2024
1 parent c598974 commit 5cd8ee0
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2229,13 +2229,11 @@ public void readEntryComplete(Entry entry, Object ctx) {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntryComplete(entry, cbCtx);
return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}", name, ledgerId, entryId);
}
entry.release();
return;
}
}

Expand All @@ -2246,7 +2244,6 @@ public void readEntryFailed(ManagedLedgerException exception, Object ctx) {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntryFailed(exception, cbCtx);
return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}", name, ledgerId, entryId);
Expand All @@ -2261,13 +2258,11 @@ public void readEntriesComplete(List<Entry> returnedEntries, Object ctx) {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntriesComplete(returnedEntries, cbCtx);
return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}", name, ledgerId, entryId);
}
returnedEntries.forEach(Entry::release);
return;
}
}

Expand All @@ -2278,12 +2273,10 @@ public void readEntriesFailed(ManagedLedgerException exception, Object ctx) {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntriesFailed(exception, cbCtx);
return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}", name, ledgerId, entryId);
}
return;
}
}

Expand Down

0 comments on commit 5cd8ee0

Please sign in to comment.