-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Java 17 for building #181
Conversation
squashing is currently forced by pulsar-client-reactive/.asf.yaml Lines 36 to 42 in 11b0de9
Docs for .asf.yaml are at https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#merge . We can change .asf.yaml for pulsar-client-reactive in a PR if we prefer to change the current settings.
|
Oh no, thats fine. This is not that important to split into 2 separate commits. We can just squash. In fact I will do that now as I am going to back off the version bump in subsequent commit. |
Keep the runtime compatibility w/ Java 8 by setting options.release. Also update to spring-javaformat 0.0.42 (requires Java 17 compile).
This proposal updates to Java 17 for building but retains Java 8 as the language level via the
options.release
flag.The second commit takes advantage of the first and updates the spring javaformat to
0.0.42
(which relies on Java 17 compilation).