Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Java 17 for building #181

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Updates to Java 17 for building #181

merged 1 commit into from
Aug 10, 2024

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Aug 9, 2024

This proposal updates to Java 17 for building but retains Java 8 as the language level via the options.release flag.

The second commit takes advantage of the first and updates the spring javaformat to 0.0.42 (which relies on Java 17 compilation).

@onobc onobc requested a review from lhotari August 9, 2024 17:35
gradle.properties Outdated Show resolved Hide resolved
@lhotari
Copy link
Member

lhotari commented Aug 9, 2024

There are 2 commits on purpose - please don't squash on commit.

squashing is currently forced by .asf.yaml settings. We would have to modify

enabled_merge_buttons:
# enable squash button:
squash: true
# disable merge button:
merge: false
# disable rebase button:
rebase: false
to enable merging without squashing.
Docs for .asf.yaml are at https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#merge . We can change .asf.yaml for pulsar-client-reactive in a PR if we prefer to change the current settings.

@onobc
Copy link
Contributor Author

onobc commented Aug 9, 2024

There are 2 commits on purpose - please don't squash on commit.

squashing is currently forced by .asf.yaml settings. We would have to modify

enabled_merge_buttons:
# enable squash button:
squash: true
# disable merge button:
merge: false
# disable rebase button:
rebase: false

to enable merging without squashing.
Docs for .asf.yaml are at https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#merge . We can change .asf.yaml for pulsar-client-reactive in a PR if we prefer to change the current settings.

Oh no, thats fine. This is not that important to split into 2 separate commits. We can just squash. In fact I will do that now as I am going to back off the version bump in subsequent commit.

Keep the runtime compatibility w/ Java 8 by setting options.release.

Also update to spring-javaformat 0.0.42 (requires Java 17 compile).
@onobc onobc merged commit ed6ce9e into apache:main Aug 10, 2024
1 check passed
@onobc onobc deleted the update-java-17 branch August 10, 2024 03:37
@onobc onobc added this to the 0.5.7 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants