Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spool] Actual implementation #14507

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

[Spool] Actual implementation #14507

wants to merge 15 commits into from

Commits on Nov 19, 2024

  1. Support stage replacement

    @gortiz
    gortiz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    982ac13 View commit details
    Browse the repository at this point in the history

  2. Verify the case where a spool tries to send twice to the same stage

    @gortiz
    gortiz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d02b5cb View commit details
    Browse the repository at this point in the history

  3. Add tests that verifies that different distribution breaks equivalence

    @gortiz
    gortiz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    05b894e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Fix root mailbox send node build using null receiver stage

    @gortiz
    gortiz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1597f5b View commit details
    Browse the repository at this point in the history

  2. Remove unused variable

    @gortiz
    gortiz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    91b1b55 View commit details
    Browse the repository at this point in the history

  3. Fix MailboxReceiveNode.equals, broken in previous spool commits

    @gortiz
    gortiz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    37168a0 View commit details
    Browse the repository at this point in the history

  4. Hide the receiver stage bit set in MailboxSendNode

    @gortiz
    gortiz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    fe22305 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Apply suggestions from code review 

    rename some test methods

Co-authored-by: Yash Mayya <[email protected]>
    @gortiz @yashmayya
    gortiz and yashmayya authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a72157f View commit details
    Browse the repository at this point in the history

  2. Make _senderStageId mutable to simplify getSenderStageId() logic

    @gortiz
    gortiz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    edf8542 View commit details
    Browse the repository at this point in the history

  3. Make StagesTestBase.Spool static

    @gortiz
    gortiz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5bff873 View commit details
    Browse the repository at this point in the history

  4. Rename Spool as SpoolBuilder and add javadoc explaining the class

    @gortiz
    gortiz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8263de3 View commit details
    Browse the repository at this point in the history

  5. Fix error added in a previous commit

    @gortiz
    gortiz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3b252cf View commit details
    Browse the repository at this point in the history

  6. Support spool in runtime. Still not complete. 

    Explain implementation is working, but not actual queries.
    @gortiz
    gortiz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    32fa712 View commit details
    Browse the repository at this point in the history

  7. Fix design issues in multi-sender MailboxSendNode

    @gortiz
    gortiz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f3bffb3 View commit details
    Browse the repository at this point in the history

  8. Add some explain physical plans with spool

    @gortiz
    gortiz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f06138a View commit details
    Browse the repository at this point in the history