Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of segment name when uploading a segment tar file #14455

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vrajat
Copy link
Collaborator

@vrajat vrajat commented Nov 14, 2024

In segment tar upload operation, the name of the segment is the file (or dir) name. Allow the client to specify a segment name instead. This feature is useful when writing tests or to simulate production workloads.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34.10%. Comparing base (59551e4) to head (fb45e2a).
Report is 1343 commits behind head on master.

Files with missing lines Patch % Lines
...ces/PinotSegmentUploadDownloadRestletResource.java 0.00% 3 Missing and 1 partial ⚠️
...egment/spi/index/metadata/SegmentMetadataImpl.java 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (fb45e2a). Click for more details.

HEAD has 43 uploads less than BASE
Flag BASE (59551e4) HEAD (fb45e2a)
integration 7 2
integration2 3 2
temurin 12 3
java-21 7 2
skip-bytebuffers-true 3 1
skip-bytebuffers-false 7 2
unittests 5 1
unittests1 2 0
java-11 5 1
unittests2 3 1
integration1 2 0
custom-integration1 2 0
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14455       +/-   ##
=============================================
- Coverage     61.75%   34.10%   -27.65%     
- Complexity      207      770      +563     
=============================================
  Files          2436     2663      +227     
  Lines        133233   146127    +12894     
  Branches      20636    22391     +1755     
=============================================
- Hits          82274    49836    -32438     
- Misses        44911    92255    +47344     
+ Partials       6048     4036     -2012     
Flag Coverage Δ
custom-integration1 ?
integration 0.00% <ø> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <ø> (ø)
java-11 0.00% <ø> (-61.71%) ⬇️
java-21 34.10% <0.00%> (-27.53%) ⬇️
skip-bytebuffers-false 0.00% <ø> (-61.75%) ⬇️
skip-bytebuffers-true 34.10% <0.00%> (+6.37%) ⬆️
temurin 34.10% <0.00%> (-27.65%) ⬇️
unittests 34.10% <0.00%> (-27.65%) ⬇️
unittests1 ?
unittests2 34.10% <0.00%> (+6.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants