-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scala3-library to 3.3.4 #1506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to discuss mima issues in #1474
Breaks some tests that check logging
|
5606f02
to
627172f
Compare
627172f
to
2afa514
Compare
Co-Authored-By: Wojciech Mazur <[email protected]>
applied the fix to determine the logging class from the stack trace from #1474 (comment) . I don't think we need to worry about performance here: the added logic should be much faster than the time it already takes to construct the stack trace in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
About this PR
π¦ Updates org.scala-lang:scala3-library from
3.3.3
to3.3.4
π GitHub Release Notes - Version Diff - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: