Add wiretap/wiretapContext to FlowWithContext/SourceWithContext #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
add-wireTap-wireTapContext-to-Flow-Source-with-context
branch
2 times, most recently
from
2429d43
to
b7cf181
Compare
pjfanning
reviewed
Aug 23, 2024
mdedetrich
force-pushed
the
add-wireTap-wireTapContext-to-Flow-Source-with-context
branch
3 times, most recently
from
4615c7a
to
8a9cd77
Compare
mdedetrich
requested review from
pjfanning,
jrudolph,
raboof,
gmethvin,
He-Pin,
nvollmar,
wu-sheng,
danischroeter,
samueleresca,
Roiocam and
laglangyue
mdedetrich
force-pushed
the
add-wireTap-wireTapContext-to-Flow-Source-with-context
branch
from
8a9cd77
to
fd88c93
Compare
|
So the tests in the PR are now working, I ended up having to use In other words its possible that in certain test runs one of the elements may be missing, which is intentional behaviour of wireTap. |
mdedetrich
force-pushed
the
add-wireTap-wireTapContext-to-Flow-Source-with-context
branch
from
fd88c93
to
9948552
Compare
|
@pjfanning Do you mind reviewing this PR? You have reviewed the previous version and its the last thing from my side for the next RC which you wanted to plan for Thursday. |
pjfanning
reviewed
Aug 27, 2024
mdedetrich
force-pushed
the
add-wireTap-wireTapContext-to-Flow-Source-with-context
branch
from
9948552
to
1d42eff
Compare
mdedetrich
deleted the
add-wireTap-wireTapContext-to-Flow-Source-with-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #1443 but with
wireTap/wireTapContext