additional mailbox selector for typed props #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Roiocam can you put the typo fixes in a separate PR? We can backfit that change. |
pjfanning
reviewed
Feb 5, 2024
...yped-tests/src/test/scala/org/apache/pekko/actor/typed/scaladsl/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
Roiocam
commented
Feb 5, 2024
| parentProbe.ref) | ||
|
|
||
| val childProbe = createTestProbe[ActorRef[Ping]]() | ||
| grandParent ! SpawnProtocol.Spawn(PingPong(), "child", Props.empty.withDispatcherSameAsParent, childProbe.ref) |
There was a problem hiding this comment.
Fix children not spawn from the parent
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
3b83298
to
8e3f603
Compare
nvollmar
reviewed
Feb 6, 2024
nvollmar
reviewed
Feb 6, 2024
nvollmar
reviewed
Feb 6, 2024
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
93fac01
to
b9b046d
Compare
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
d1302b7
to
7cbc958
Compare
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
7cbc958
to
9c1022f
Compare
pjfanning
reviewed
Feb 6, 2024
actor-typed-tests/src/test/scala/docs/org/apache/pekko/typed/MailboxDocSpec.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Feb 6, 2024
pjfanning
reviewed
Apr 26, 2024
| import org.apache.pekko | ||
| import pekko.actor.typed.DispatcherSelector |
There was a problem hiding this comment.
can you reorder the imports and put back the empty line above?
There was a problem hiding this comment.
Sorry about the delay, could you review this again and contain this in release 1.1.0?
pjfanning
approved these changes
Aug 23, 2024
pjfanning
requested review from
jrudolph,
raboof,
He-Pin,
mdedetrich and
samueleresca
|
@mdedetrich would you have time to review this? I'm hoping to get the RC for v1.1.0 together in the next few days. |
|
I will look at it tonight |
|
@kerr would you have time to review this? |
mdedetrich
approved these changes
Aug 28, 2024
|
I looked again and I think this is pretty safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have experience in migrating Classic to Typed. In the process, I found that Typed can't customize Mailbox through Props. We should match the same Classic method on Typed.
TODO list