Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal home with Paradox #47

Merged
merged 10 commits into from
Jan 4, 2024
Merged

Conversation

samueleresca
Copy link
Member

@samueleresca samueleresca commented Dec 20, 2023

The following PR is related to the following disscussions:

Few notes:

I attach the visual results of the changes:
proposal_1
proposal_1_low_res

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copying this non ASF, non Apache licensed code to here means we need to change the LICENSE and NOTICE for this repo.

README.md Show resolved Hide resolved
build.sbt Show resolved Hide resolved
@samueleresca
Copy link
Member Author

copying this non ASF, non Apache licensed code to here means we need to change the LICENSE and NOTICE for this repo.

I might have found a better approach to this, see: apache/pekko-sbt-paradox#85. The change would allow to have a stylesheet dedicated to the page on top of the common theme stylesheet.

If this approach is successful we don't need to override home.st at all

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laglangyue
Copy link
Contributor

LGTM,good works.
For better:
could you test with google translator, no need for very strict testing,
because some developers are not native English speakers.

@samueleresca
Copy link
Member Author

I standby on merging this I want to proceed first with: apache/pekko-sbt-paradox#84 (less moving piecies)

@samueleresca
Copy link
Member Author

LGTM,good works. For better: could you test with google translator, no need for very strict testing, because some developers are not native English speakers.

Good point, I will do a bit of testing on other langs before merging

@samueleresca samueleresca changed the title Proposal home with Paradox [DO NOT MERGE] Proposal home with Paradox Dec 22, 2023
@samueleresca
Copy link
Member Author

@pjfanning I'm proceeding today by resolving conflicts with #54 and re-test the changes. I'm might send over the PR for another approval

@samueleresca
Copy link
Member Author

LGTM,good works. For better: could you test with google translator, no need for very strict testing, because some developers are not native English speakers.

@laglangyue I verified the page with google transltor localized in multiple lang. The spacing and the menu respond correctly. If you have any specific lang you want to test please let me know.

@samueleresca samueleresca changed the title [DO NOT MERGE] Proposal home with Paradox Proposal home with Paradox Jan 3, 2024
@@@

@@@ div { .navigation}
* @ref:[Samples](samples.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples and modules seem now to appear to in the index page

There are probably links to the old samples and modules pages so we should probably go to our other docs to check for links and repoint them to the index page. We should be planning in near future to remove the samples and modules pages. We could add .htaccess redirects to redirect those links to the index page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to keep samples.md and modules.md as dedicated pages. I just noticed that using ## Modules in the index.md plays funny with the navigation menu of the other pages.

I have updated index.md to declare the 2 subtitles "Sample" and "Modules" that do not interfere with the structure of the other pages.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samueleresca samueleresca merged commit 7b49517 into apache:main Jan 4, 2024
@samueleresca
Copy link
Member Author

Proceeding with the rebase in asf-staging and asf-site in the afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants