-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal home with Paradox #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copying this non ASF, non Apache licensed code to here means we need to change the LICENSE and NOTICE for this repo.
I might have found a better approach to this, see: apache/pekko-sbt-paradox#85. The change would allow to have a stylesheet dedicated to the page on top of the common theme stylesheet. If this approach is successful we don't need to override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM,good works. |
I standby on merging this I want to proceed first with: apache/pekko-sbt-paradox#84 (less moving piecies) |
Good point, I will do a bit of testing on other langs before merging |
@pjfanning I'm proceeding today by resolving conflicts with #54 and re-test the changes. I'm might send over the PR for another approval |
Adding how-to-contribute. Updating.
40554be
to
d1231a0
Compare
@laglangyue I verified the page with google transltor localized in multiple lang. The spacing and the menu respond correctly. If you have any specific lang you want to test please let me know. |
c2d0989
to
5892d47
Compare
@@@ | ||
|
||
@@@ div { .navigation} | ||
* @ref:[Samples](samples.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples and modules seem now to appear to in the index page
There are probably links to the old samples and modules pages so we should probably go to our other docs to check for links and repoint them to the index page. We should be planning in near future to remove the samples and modules pages. We could add .htaccess redirects to redirect those links to the index page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to keep samples.md
and modules.md
as dedicated pages. I just noticed that using ## Modules
in the index.md
plays funny with the navigation menu of the other pages.
I have updated index.md
to declare the 2 subtitles "Sample" and "Modules" that do not interfere with the structure of the other pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Proceeding with the rebase in |
The following PR is related to the following disscussions:
Few notes:
In order to add a dedicated style to the page, I need to override the theSolved by: Adding a dedicated stylesheet to the page layout pekko-sbt-paradox#85home.st
to include the styling.I attach the visual results of the changes: