Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scala steward #99

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add scala steward #99

merged 1 commit into from
Feb 14, 2024

Conversation

mdedetrich
Copy link
Contributor

Add scala steward

pjfanning
pjfanning approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - but INFRA only enable this one repro at a time, so you will need to contact them

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Feb 14, 2024 •
edited
Loading

lgtm - but INFRA only enable this one repro at a time, so you will need to contact them

Afaik I explicitly told them to enable all incubator-pekko-* repo's, lets confirm when the runner gets executed.

@pjfanning
Copy link
Contributor

lgtm - but INFRA only enable this one repro at a time, so you will need to contact them

Afaik I explicitly told them to enable all incubator-pekko-* repo's, lets confirm when the runner gets executed.

they told me this when I enabled scala steward for pekoo-connectors recently

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Feb 14, 2024 •
edited
Loading

they told me this when I enabled scala steward for pekoo-connectors recently

I see, ill do this later.

@mdedetrich mdedetrich merged commit 3d93c33 into apache:main Feb 14, 2024
5 checks passed
@mdedetrich mdedetrich deleted the add-scala-steward branch February 14, 2024 22:44
@mdedetrich
Copy link
Contributor Author

they told me this when I enabled scala steward for pekoo-connectors recently

@pjfanning Do you have an example ticket for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning approved these changes

@jrudolph jrudolph Awaiting requested review from jrudolph

@raboof raboof Awaiting requested review from raboof

@gmethvin gmethvin Awaiting requested review from gmethvin

@He-Pin He-Pin Awaiting requested review from He-Pin

@nvollmar nvollmar Awaiting requested review from nvollmar

@seglo seglo Awaiting requested review from seglo

@samueleresca samueleresca Awaiting requested review from samueleresca

@jxnu-liguobin jxnu-liguobin Awaiting requested review from jxnu-liguobin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @pjfanning