Use sbt-paradox-material-theme 0.7.0 #92
Conversation
mdedetrich
requested review from
pjfanning,
jrudolph,
raboof,
Roiocam,
jxnu-liguobin,
samueleresca,
He-Pin and
gmethvin
mdedetrich
force-pushed
the
use-sbt-paradox-theme-0.7.0
branch
from
a4dbd50
to
2390e3f
Compare
LICENSE
Outdated
| @@ -202,8 +202,8 @@ | |||
|
|
|||
| --------------- | |||
|
|
|||
| pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0, | |||
| which was released under an MIT license <https://github.com/jonas/paradox-material-theme>. | |||
| pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0, | |||
There was a problem hiding this comment.
I would prefer not to change the license - the original text is more accurate because that is where we borrowed the code from. Likewise for the links in the source code.
There was a problem hiding this comment.
You mean the license itself or the license file (the license is still the same, there was no project relicensing)? The main reason for updating this is the repo location has changed (from https://github.com/jonas/paradox-material-theme to https://github.com/sbt/sbt-paradox-material-theme) and I am not sure how long github redirects are guaranteed for.
There was a problem hiding this comment.
ok - since the repo has moved - then we can change the links
Can we change the version back though?
pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0
We adapted this code before 0.7.0 was released.
There was a problem hiding this comment.
@pjfanning Done, I checked and it lgtm but ill wait for your review just to make sure.
mdedetrich
force-pushed
the
use-sbt-paradox-theme-0.7.0
branch
from
2390e3f
to
264e07e
Compare
See sbt/sbt-paradox-material-theme#59