Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index toc rendering issue #87

Closed
wants to merge 3 commits into from

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Jan 17, 2024

Fixes apache/pekko#975 (comment)

We can remove those element not belong the selected group.

@Roiocam
Copy link
Member Author

Roiocam commented Jan 24, 2024

This PR hides the element when toc header link is not the current group, I have verified this on my laptop.

But after PR #86 and #84, this plugin won't render the navigator anymore, because we put these render scripts to CDN,

you could verify this PR following this way:

  1. checkout to the latest pekko project
  2. nothing to do and then clean up and docs/paradoxBrowse, which means compile doc with the paradox
  3. use this PR script to replace docs/target/paradox/site/main/assets/javascripts/groups.js
  4. open the browser and refresh pekko doc page
Select Current Group to Java 截屏2024-01-24 10 30 24
Select Current Group to Scala 截屏2024-01-24 10 30 27

@Roiocam Roiocam marked this pull request as ready for review January 24, 2024 02:40
@Roiocam
Copy link
Member Author

Roiocam commented Jan 24, 2024

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm, but there is conflict. @Roiocam

@Roiocam
Copy link
Member Author

Roiocam commented Jan 24, 2024

close and reopen in the right repo: apache/pekko-site#72

@Roiocam Roiocam closed this Jan 24, 2024
@Roiocam Roiocam deleted the index-toc-rendering-issue branch January 26, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Style Guide document render issue
2 participants