Better clarify excludeAll statement #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
gmethvin,
He-Pin,
samueleresca,
pjfanning,
Roiocam and
jxnu-liguobin
raboof
reviewed
Mar 4, 2024
README.md
Outdated
| > JDK 11 reference, i.e. if you need to use sbt-site-paradox you would do the | ||
| > following | ||
| > resolved dependencies that rely on JDK 11+, i.e. if you need to use | ||
| > * sbt-site-paradox you would do the following |
There was a problem hiding this comment.
wouldn't that * start a new bullet?
Suggested change
| > * sbt-site-paradox you would do the following | |
| > sbt-site-paradox you would do the following |
There was a problem hiding this comment.
Thanks for pickup
There was a problem hiding this comment.
Resolved + force pushed
mdedetrich
force-pushed
the
better-clarify-excludeAll-statement
branch
from
73ee528
to
02f51be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current wording is misleading