Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding source.st excluding the data-md-source attribute. #121

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

samueleresca
Copy link
Member

Removing data-md-source to avoid external 3rd party calls to GH.

See: #110

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samueleresca samueleresca merged commit 5e25566 into apache:main Feb 28, 2024
5 checks passed
@samueleresca samueleresca deleted the removing-data-md-source branch February 28, 2024 13:19
@pjfanning
Copy link
Contributor

I tried this out on my laptop and it seems to work well. The GitHub link appears but we don't seem to get the api.github.com calls.

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants