Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update sbt to 1.10.2" #607

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Sep 22, 2024

Reverts #606

Causing build issues. I've just attempted to build v1.1.0-RC1 and saw issues that have appeared in other repos.

Also happened in https://github.com/apache/pekko-http/actions/runs/10977419460/job/30479347399

 java.util.zip.ZipException: duplicate entry: META-INF/LICENSE
[error] 	at java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:232)
[error] 	at java.util.jar.JarOutputStream.putNextEntry(JarOutputStream.java:109)
[error] 	at sbt.io.IO$.addFileEntry$1(IO.scala:717)
[error] 	at sbt.io.IO$.$anonfun$writeZip$6(IO.scala:726)
[error] 	at sbt.io.IO$.$anonfun$writeZip$6$adapted(IO.scala:726)
[error] 	at scala.collection.immutable.List.foreach(List.scala:431)
[error] 	at sbt.io.IO$.writeZip(IO.scala:726)
[error] 	at sbt.io.IO$.$anonfun$archive$2(IO.scala:676)
[error] 	at sbt.io.IO$.$anonfun$archive$2$adapted(IO.scala:673)
[error] 	at sbt.io.IO$.$anonfun$withZipOutput$1(IO.scala:773)
[error] 	at sbt.io.IO$.$anonfun$withZipOutput$1$adapted(IO.scala:753)
[error] 	at sbt.io.Using.apply(Using.scala:28)
[error] 	at sbt.io.IO$.withZipOutput(IO.scala:753)
[error] 	at sbt.io.IO$.archive(IO.scala:673)
[error] 	at sbt.io.IO$.jar(IO.scala:638)
[error] 	at sbt.Package$.makeJar(Package.scala:229)
[error] 	at sbt.Package$.$anonfun$apply$4(Package.scala:152)
[error] 	at sbt.Package$.$anonfun$apply$4$adapted(Package.scala:150)
[error] 	at sbt.util.Tracked$.$anonfun$outputChangedW$1(Tracked.scala:129)
[error] 	at sbt.Package$.apply(Package.scala:162)
[error] 	at sbt.Defaults$.$anonfun$packageTask$1(Defaults.scala:1918)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:63)
[error] 	at sbt.std.Transform$$anon$4.work(Transform.scala:69)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:283)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:24)
[error] 	at sbt.Execute.work(Execute.scala:292)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:283)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:65)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] 	at java.lang.Thread.run(Thread.java:750)

I think it is best to revert and to worry about fixing the underlying issue later.

Copy link

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 02c9b55 into main Sep 22, 2024
10 checks passed
@pjfanning pjfanning deleted the revert-606-update/sbt-1.10.2 branch September 22, 2024 13:15
@raboof
Copy link
Member

raboof commented Sep 22, 2024

That seems like that wise thing to do. I wonder if it somehow has something to do with apache/pekko#1470 .

@raboof
Copy link
Member

raboof commented Sep 22, 2024

Did some digging, this is a change in behavior in sbt that is causing trouble with sbt-apache-sonatype, mdedetrich/sbt-apache-sonatype#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants