Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimumExpectedPekkoVersion to 1.0.0 #328

Merged

Conversation

mdedetrich
Copy link
Contributor

Resolves #327 (comment)

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong - in test logs.

[info] Building Pekko HTTP 1.1.0-M0+12-1b020099+20231010-1800-SNAPSHOT against Pekko 1.0.0 on Scala 2.12.18

I think we need to fix the build so that it tests against Pekko 1.0.1 - the latest 1.0.x release - or we could test with the latest 1.0.x snapshot. I think it is bad to test with Pekko 1.0.0.

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Oct 10, 2023

@pjfanning So whether or not to use the snapshot is derived by the "pekko.http.build.pekko.version" which you can see here https://github.com/apache/incubator-pekko-http/blob/7f1441ee25d864a9cbc441eba92199598e26ea01/project/PekkoDependency.scala#L45

and currently this is being set for nightlies, i.e.
https://github.com/apache/incubator-pekko-http/blob/57dcb5dcc64b4c269d83a01909a7a39dcd32bf71/.github/workflows/nightly.yml#L44-L48

You can verify this by looking at https://github.com/apache/incubator-pekko-http/actions/runs/6463888406/job/17547697024, i.e.

[info] Building Pekko HTTP 1.1.0-M0+10-4eccd171+20231010-0214-SNAPSHOT against Pekko 1.1.0-M0+101-1b1f5722-SNAPSHOT on Scala 2.12.18

I think this is fine and intentional, i.e. we really should set minimumExpectedPekkoVersion to be 1.0.0 because its not correct that Pekko Http requires 1.0.1 and its basically breaking end users.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I'll check the nightlies logs in the morning just in case

@mdedetrich mdedetrich merged commit 9de3848 into apache:main Oct 10, 2023
9 of 10 checks passed
@mdedetrich mdedetrich deleted the downgrade-minimum-pekko-http-version branch October 10, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pekko requires non-existent dependency version
2 participants