Skip to content

Commit

Permalink
Increase stream-cancellation-delay default to 1000 millis (#590)
Browse files Browse the repository at this point in the history
  • Loading branch information
mdedetrich authored Sep 4, 2024
1 parent 4349a03 commit 932a22f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions docs/src/main/paradox/release-notes/releases-1.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ All the changes in the @ref:[1.0.x releases](releases-1.0.md) up to and includin
### Changes
* Changed names of HTTP status codes 413 and 422 ([PR87](https://github.com/apache/pekko-http/pull/87))
* Parse entire HTTP chunk size ([PR528](https://github.com/apache/pekko-http/pull/528))
* Increased default value of `pekko.http.server.stream-cancellation-delay` and `pekko.http.client.stream-cancellation-delay` from 100 to 1000 millis ([PR590](https://github.com/apache/pekko-http/pull/590))

### Additions
* Add UnsupportedContentTypeException Java DSL ([PR376](https://github.com/apache/pekko-http/pull/376))
Expand Down
4 changes: 2 additions & 2 deletions http-core/src/main/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ pekko.http {
# In most cases, there should be no reason to change this setting.
#
# Set to 0 to disable the delay.
stream-cancellation-delay = 100 millis
stream-cancellation-delay = 1000 millis

http2 {
# The maximum number of request per connection concurrently dispatched to the request handler.
Expand Down Expand Up @@ -532,7 +532,7 @@ pekko.http {
# In most cases, there should be no reason to change this setting.
#
# Set to 0 to disable the delay.
stream-cancellation-delay = 100 millis
stream-cancellation-delay = 1000 millis
}
#client-settings

Expand Down
1 change: 1 addition & 0 deletions http-core/src/test/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ pekko {
default-dispatcher.throughput = 1
}
stream.materializer.debug.fuzzing-mode = off
stream.testkit.all-stages-stopped-timeout = 20 s
}
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ class H2SpecIntegrationSpec extends PekkoFreeSpec(
executable,
"-k", "-t",
"-p", port.toString,
"-o", "9",
"-j", junitOutput.getPath) ++
specSectionNumber.toList.map(number => s"http2/$number")

Expand Down

0 comments on commit 932a22f

Please sign in to comment.