Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use env variables for AWS creds #833

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pjfanning
Copy link
Contributor

see #832

not yet for merge - contains some build hacks to test the changes in a PR

@pjfanning pjfanning marked this pull request as draft September 26, 2024 11:15
@pjfanning
Copy link
Contributor Author

@jtjeferreira the tests have access to the the AWS creds in this PR

The KinesisITTest fails because we don't have the specific AWS permissions to create the Kinesis resources needed for that test.

@jtjeferreira
Copy link
Contributor

The KinesisITTest fails because we don't have the specific AWS permissions to create the Kinesis resources needed for that test.

Can you take care of that?

@pjfanning
Copy link
Contributor Author

The KinesisITTest fails because we don't have the specific AWS permissions to create the Kinesis resources needed for that test.

Can you take care of that?

Is there any chance that we could start with using localstack or something like that to test with an AWS-like setup for our Kinesis related testing?

I can put some details in #655 and we can follow up on that later. I'd prefer if an ASF volunteer with an AWS account was able to take that task on. It's easier to sort that out by testing with a personal AWS setup and then being able to go to the ASF Infra team with a detailed setup that they can implement for us.

@jtjeferreira
Copy link
Contributor

Is there any chance that we could start with using localstack or something like that to test with an AWS-like setup for our Kinesis related testing?

I was gonna say that we already have that, because I think I wrote something like that in the past, but I might be mixing up. I can do that but it wont help me with this puzzle #830

I'd prefer if an ASF volunteer with an AWS account was able to take that task on. It's easier to sort that out by testing with a personal AWS setup and then being able to go to the ASF Infra team with a detailed setup that they can implement for us.

I have access to an AWS account, but I am not sure what the ASF infra team needs? How was the S3 setup done? Was that discussion public? If yes can you link me to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants