Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove code copied from gist #198

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Conversation

pjfanning
Copy link
Contributor

  • the code has no license specified
  • if it turns out that we need this test code, we will need to either see if scalatest supports retries now (eventually works well)
  • or approach the author to see if he will grant us permission to license the gist

@mdedetrich
Copy link
Contributor

I think this can be replaced with what I did in apache/pekko#471 or with something like

lazy val root = Project("test", file(".")).
  settings(commands += Command.command("testUntilFailed") { state =>
    "test" :: "testUntilFailed" :: state
  })

Which lets you run tests until they fail. I am actually thinking of putting both of these into an sbt-plugin (under my org) because they are generally useful.

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit aa60960 into apache:main Jul 22, 2023
@pjfanning pjfanning deleted the remove-gist branch July 22, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants