Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2409: Add custom .asf.yaml for email notification #224

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented Dec 5, 2023

Make sure you have checked all steps below.

Jira

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@wgtmac
Copy link
Member Author

wgtmac commented Dec 5, 2023

PTAL. Thanks! @pitrou @gszadovszky @shangxinli

@pitrou
Copy link
Member

pitrou commented Dec 5, 2023

@kou Does the file syntax look ok?

@wgtmac
Copy link
Member Author

wgtmac commented Dec 5, 2023

@kou Does the file syntax look ok?

I copied this from https://github.com/apache/zookeeper/blob/master/.asf.yaml

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We may want to copy the comment too:

https://github.com/apache/zookeeper/blob/ceebda9493bd2e406973e1f4a7f77f9e0121ba16/.asf.yaml#L20C3-L20C77

The document is difficult to find...

@wgtmac
Copy link
Member Author

wgtmac commented Dec 6, 2023

Thanks for the suggestion! @kou

@wgtmac wgtmac merged commit eb4b31c into apache:master Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants