HDDS-11627. Support getBlock operation on short-circuit channel. #7456
+3,370
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current CI build will fail due to new DomainSocket#close(boolean) API is not available in Hadoop common 3.3.6 jar. |
smengcl
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Is it a good idea to include binary like this?
Does the binary come from a released hadoop version? If so, should we write a script snippet to download the tarball and extract the binary from that instead?
There was a problem hiding this comment.
This is only for integration test, like the ozone-site.xml files under many test/resources folders. It will not be used in the final dist package and deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11627
How was this patch tested?
new unit tests and integration tests.