HDDS-11480. Refactor OM volume response tests #7265
Merged
+101
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandika3
reviewed
Oct 3, 2024
There was a problem hiding this comment.
@harryteng9527 Thanks for picking this up. Overall looks good. Could you help resolve the checkstyle and rat (license) failure first?
...e-manager/src/test/java/org/apache/hadoop/ozone/om/response/volume/TestOMVolumeResponse.java
Show resolved
Hide resolved
sarvekshayr
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Thanks @harryteng9527 for this patch.
LGTM, waiting for green CI.
ivandika3
approved these changes
Oct 3, 2024
|
Thanks @harryteng9527 for the patch and @sarvekshayr for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR extracts the bootstrap methods (
setup(),tearDown()) used in the following OM volume response tests to reduce redundant code by allowing the tests to inherit from a superclass:What is the link to the Apache JIRA
HDDS-11480. Refactor OM volume response tests
How was this patch tested?