HDDS-11442. Add dashboard for memory consumption metrics #7198
Conversation
There was a problem hiding this comment.
Thank you @len548 for working on the patch, please find a few comments below.
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "PBFA97CFB590B2093" |
There was a problem hiding this comment.
We could consider skipping the inclusion of the datasource uid to simplify the import process for users.
Ref: grafana/grafana#60769
There was a problem hiding this comment.
Agreed. I left the uid because I assumed it wouldn't display any data without uid. Now pushed new change that excludes uids.
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "PBFA97CFB590B2093" |
There was a problem hiding this comment.
Same as the previous comment, we could skip the datasource uid field in all instances
| "timepicker": {}, | ||
| "timezone": "browser", | ||
| "title": "Ozone - Memory Consumption Metrics", | ||
| "uid": "fdtf5eoqt93pcc", |
There was a problem hiding this comment.
On similar lines, we could exclude the uid field for the dashboard as well!
| "options": { | ||
| "mode": "exclude", | ||
| "names": [ | ||
| "{__name__=\"jvm_metrics_threads_new\", context=\"jvm\", hostname=\"ccycloud-1.renkoike.root.comops.site\", instance=\"ccycloud-1.renkoike.root.comops.site:9876\", job=\"ozone\", processname=\"StorageContainerManager\", sessionid=\"null\"}" |
There was a problem hiding this comment.
We may utilize {{hostname}} instead for all instances where we are hardcoding the hostnames (Ref: link).
|
@tanvipenumudy @kerneltime Hi, I merged some changes based on the comments and would like you to review it. Thank you for your time! |
| }, | ||
| "disableTextWrap": false, | ||
| "editorMode": "builder", | ||
| "expr": "jvm_metrics_cpu_jvm_load{instance=\"om:9874\"}", |
There was a problem hiding this comment.
Query for both OM ports similar to https://github.com/apache/ozone/blob/master/hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone%20-%20JVM%20Metrics.json#L313
| }, | ||
| "disableTextWrap": false, | ||
| "editorMode": "builder", | ||
| "expr": "jvm_metrics_mem_heap_used_m{processname=\"OzoneManager\"}", |
There was a problem hiding this comment.
For memory you can select the unit to help plotting the Y axis
| }, | ||
| "disableTextWrap": false, | ||
| "editorMode": "builder", | ||
| "expr": "om_metrics_num_keys", |
There was a problem hiding this comment.
You can select the unit as StandardOptions:Misc:Short to see the numbers of millions or billions of files
|
/pending review comments |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Marking this issue as un-mergeable as requested.
Please use /ready comment when it's resolved.
Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)
review comments
What changes were proposed in this pull request?
Added
Ozone - Memory Consumption Metrics.jsonto measure memory consumption for the services: OM, SCM, DN and Recon. The following metrics are tracked:Also, the dashboard includes these metrics for Ozone:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11442
How was this patch tested?
Deployed locally.
