Deploy with new scheduler #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunhoffe
changed the title
21 tasks
|
Having issues with inProgressJobRetention parsing in new scheduler image, see: apache/openwhisk#5281 |
hunhoffe
commented
Jul 13, 2022
hunhoffe
force-pushed
the
newscheduler
branch
from
d0c5bc5
to
1ce862a
Compare
hunhoffe
commented
Sep 14, 2022
style95
reviewed
Sep 15, 2022
|
@hunhoffe |
Rename scheduler_enable config to scheduler_enabled to match existing config. Support enabled fully in values.schema.json for the scheduler config.
|
I believe I've addressed all comments except the external etcd feature. I wrote a comment that it is not yet supported in the values.yaml file, and I'm hoping that it is a feature that could be added later; I could create an issue for it so it is not forgotten if that's acceptable. |
hunhoffe
commented
Sep 21, 2022
I am ok with this. |
|
I created an issue for the external etcd support and fixed the timestamp (#751). Pending any further feedback, I believe this is ready for merge. Thank you for your time in reviewing @style95 and @dgrove-oss! |
hunhoffe
requested review from
dgrove-oss and
style95
and removed request for
dgrove-oss
dgrove-oss
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR contains:
Some changes are needed to the scheduler to support the akka cluster discovery mechanism. The scheduler also needs to be integrated into the build process. These changes are in PR#5278 of apache/openwhisk.
Tasks:
apache/openwhiskwith Akka cluster management changes for scheduler, controller & updates to scripts that create docker images, etc.Future Work: