Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) #795

Merged
merged 3 commits into from
May 19, 2024

Conversation

PierreSmits
Copy link
Member

ofbizsetup uses profile screens from partymgr.

modified web.xml

  • added profileMenuLocation

…zed (OFBIZ-12951)

ofbizsetup uses profile screens from partymgr.

modified web.xml
- added profileMenuLocation
@JacquesLeRoux
Copy link
Contributor

JacquesLeRoux commented May 4, 2024

Hi @PierreSmits ,

After applying and a restart, I still get :
ERROR MESSAGE

java.lang.RuntimeException: Error rendering included menu named [MainActionMenu] at location [component://commonext/widget/ofbizsetup/Menus.xml]: java.lang.IllegalArgumentException: Could not find menu with name [MainActionMenu] in location [component://commonext/widget/ofbizsetup/Menus.xml]

Obviously MainActionMenu is not profileMenuLocation.

ofbizsetup is dependent on party elements

modified: commonext
- web.xml: added new context-param for createNewParty menu

modified: party
- web.xml: added new context-param for createNewParty menu
- PartyScreens.xml: changed location createNewParty menu reference
…zed (OFBIZ-12951)

modified: Menus.xml
- added MainActionMenu extending MainActionMenu in PartyMenus.xml
Copy link

sonarcloud bot commented May 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JacquesLeRoux JacquesLeRoux merged commit 24d42f3 into apache:trunk May 19, 2024
6 checks passed
@PierreSmits PierreSmits deleted the OFBIZ-12951 branch May 19, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants