Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuttx/libxx: Simplify compilation warnings for passing CXXFLAGS. #13719

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

cuiziwei1
Copy link
Contributor

Summary

Remove the judgment of GCCVER and add CXXFLAGS directly. If there is a problem that the compiler cannot recognize the compilation options, add it separately.

Impact

Testing

@github-actions github-actions bot added Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Sep 29, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 29, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Why is this change necessary? What problem does it solve?
    • What functional part of the code is being changed (be specific)?
    • How does removing the GCCVER judgment and adding CXXFLAGS directly address the issue?
  • Impact:
    • You've left all impact sections blank. Address ALL of these:
      • New features?
      • User impact?
      • Build process changes?
      • Hardware (arch, board, driver) changes?
      • Documentation needs?
      • Security implications?
      • Compatibility concerns (backward, forward, interoperability)?
      • Anything else to consider?
  • Testing:
    • Insufficient detail:
      • Specify the exact build host operating system, CPU architecture, and compiler version.
      • Specify the exact target architectures, boards, and configurations used for testing.
    • Missing logs: Provide actual testing logs from before and after the change.

Recommendations:

  1. Explain the "Why": Clearly articulate the problem that this change solves. Is there a bug report or feature request this relates to?
  2. Be Specific: Don't use vague terms. Name the specific files, functions, or configuration options being modified.
  3. Complete Impact Assessment: Think through all potential consequences of this change, even if they seem minor.
  4. Provide Detailed Testing Information: Give reviewers the information they need to reproduce your testing environment and verify your results.

@xiaoxiang781216 xiaoxiang781216 merged commit 97359a7 into apache:master Oct 6, 2024
29 checks passed
@cuiziwei1 cuiziwei1 deleted the new_cxx branch October 18, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants