Maven remote index migration and refactoring #7976
Draft
+1,071
−937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moves about half of the code into a dedicated class - queries moved to NexusRepositoryQueries - index management remains in NexusRepositoryIndexManager
mbien
added
Code cleanup
Maven
conditions: - both cache folders share the same parent - cache folder is from an older release - index is still fairly recent - current NB instance is not a dev version
mbien
force-pushed
the
remote-index-migration
branch
from
d848634
to
ac8c041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring: split
NexusRepositoryIndexerImplto make it more maintainableNexusRepositoryQueriesNexusRepositoryIndexManagerautomatically move remote maven index from old into current cache, if:
note:
this isn't well tested yet.
-J-Dmaven.indexing.diag.release=25can be used to simulate a release version (would move the index from <25 into the cache forcurrentif above conditions apply)