Robustness of the "Goto Type Dialog"

[jtulach]

I started to see following exception when using the "GoTo Type Dialog" and the dialog stop showing anything:

java.lang.UnsupportedOperationException
        // deep stack skipped
        at org.netbeans.modules.lsp.client.bindings.TypeProviderImpl.computeTypeNames(TypeProviderImpl.java:54)
        at org.netbeans.modules.jumpto.type.GoToTypeAction$Worker.getTypeNames(GoToTypeAction.java:614)
        at org.netbeans.modules.jumpto.type.GoToTypeAction$Worker.run(GoToTypeAction.java:522)
        at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1403)
        at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
        at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)
        at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2018)

It is not good when a single broken provider brakes everything. This PR catches exceptions from each provider, logs the exception coming from TypeProvider.computeTypeNames and goes on and querying the other providers. With this fix I see the exception in the log, but _"Goto Type Dialog" continues to work as expected.

[lahodaj]

Looks reasonable to me.

[neilcsmith-net]

@jtulach please read NOTICE emails. Only @ebarboni or @MartinBalin should be merging to delivery.

https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery

[mbien]

tbh it is easy to overlook when the branch target is changed by a reviewer. My inspector gadget senses tell me that @jtulach probably saw the approval and simply merged, thinking that the PR will land in master.

but there was likely no harm done here, since the branch was pre-version bump, so the merge commit didn't blow up.

[JaroslavTulach]

@jtulach please read NOTICE emails. Only @ebarboni or @MartinBalin should be merging to delivery.

https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery

Opps. I wanted to merge to master. Certainly I haven't changed the target branch!

lahodaj changed the base branch from master to delivery
easy to overlook when the branch target is changed by a reviewer.

I haven't noticed the change. I only checked Jan's message - I wasn't expecting target branch change.

likely no harm done here, since the branch was pre-version bump, so the merge commit didn't blow up.

Benefit of being behind the HEAD. Sorry for the ripples. @ebarboni or @MartinBalin feel free to keep or remove the change from delivery.

[ebarboni]

it's fine, sync PR created.