Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code preview for “search results” #7779

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

troizet
Copy link
Collaborator

@troizet troizet commented Sep 22, 2024

I often have to use the find in projects feature, and I really miss being able to quickly see the contents of files in the search results. I have to open tabs in the main editor, which sometimes leads to a lot of unnecessary tabs.

Example of code preview:

search_results_preview_example.mp4

I borrowed the preview implementation from replace in projects:
https://github.com/apache/netbeans/blob/master/platform/api.search/src/org/netbeans/modules/search/ui/BasicReplaceResultsPanel.java

@troizet troizet added Platform [ci] enable platform tests (platform/*) UI User Interface labels Sep 22, 2024
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Oct 10, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troizet would you like to rebase this PR to latest master so that this can be tested together with your other preview window improvements?

@mbien mbien added this to the NB24 milestone Oct 10, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great!

@mbien mbien merged commit a0fbfed into apache:master Oct 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*) UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants