Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce image sizes in NB Platform Quickstart tutorial #649

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

icojb25
Copy link

@icojb25 icojb25 commented Mar 11, 2023

The current image sizes are very large in the NB Platform quickstart tutorial which makes reading it quick tricky (scrolling up and down to find the text), so I've suggested we reduce the image sizes slightly

Copy link
Contributor

@vieiro vieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, does this work on mobile devices as well? What happens if you read the result on a mobile phone? Maybe we want to use different units (as in https://docs.asciidoctor.org/asciidoc/latest/macros/image-size/)?

@mbien
Copy link
Member

mbien commented Mar 11, 2023

so, the giant screenshot appeared after #648 as mentioned #648 (comment) :)

I am no expert with this website either, but noticed that there are two variants of the screenshots:
https://github.com/apache/netbeans-website/blob/10170847062a64cb7024556aeb0ca97198a72c24/netbeans.apache.org/src/content/tutorials/images/quickstart_platform_new-api-1.png (full component)
https://github.com/apache/netbeans-website/blob/f03ab9809fab1bf7755ab9b92ef37615ca973793/netbeans.apache.org/src/content/tutorials/images/quickstart-platform_73_new-api-1.png (cropped version highlighting a smaller part)

and the last PR switched from cropped to full (to fix some links). So... lets switch it back selectively?

@vieiro
Copy link
Contributor

vieiro commented Mar 11, 2023

so, the giant screenshot appeared after #648 as mentioned #648 (comment) :)

I am no expert with this website either, but noticed that there are two variants of the screenshots: https://github.com/apache/netbeans-website/blob/10170847062a64cb7024556aeb0ca97198a72c24/netbeans.apache.org/src/content/tutorials/images/quickstart_platform_new-api-1.png (full component) https://github.com/apache/netbeans-website/blob/f03ab9809fab1bf7755ab9b92ef37615ca973793/netbeans.apache.org/src/content/tutorials/images/quickstart-platform_73_new-api-1.png (cropped version highlighting a smaller part)

and the last PR switched from cropped to full (to fix some links). So... lets switch it back selectively?

Ah, I see.

Well, one can use "Clickable Screenshots", so that the "small image" can be clicked to show a "larger detailed one", for an example on how to do this see https://netbeans.apache.org/kb/docs/contributing.html#_clickable_screenshots

If small images are available, I'd suggest using these smaller images and make them clickable to the larger ones.

@mbien
Copy link
Member

mbien commented Mar 11, 2023

on closer look: one screenshot uses metal and the other uses windows LAF, which might be slightly confusing if it changes on click.

@dat-linux
Copy link

dat-linux commented May 5, 2023

none of the images are appearing, the links are pointing to the wrong folder

here's an incorrect example:

src="images/nbm-googlebar/new-project-3.png"

not only does it point to non existing folder, but the image names are all wring. This looks like some kind of migration process of the images failed to address the links.

@ebarboni
Copy link
Contributor

@dat-linux https://netbeans.apache.org/tutorials/nbm-quick-start.html seems to have all the images.
You are writing about another page ?

@ebarboni
Copy link
Contributor

ebarboni commented Aug 1, 2023

#669 should improve the situation for missing images. But we kind of need a common way to thumbnail or manage the large image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants