-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8285] Implement mvnenc CLI tool #1793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We REQUIRE interactive for init wizard, and these params made no sense. So let's drop them for now, will return if needed.
* init goal obey "hidden" meta (so LEGACY cannot be set as def dispatcher) * settings decrypter create WARN severity problems if legacy pw found * session factory ALWAYS emits problems, unlike in mvn3 when these are logging ONLY in -X mode
not placeholder.
gnodet
reviewed
Oct 14, 2024
@@ -167,7 +167,7 @@ under the License. | |||
<assertjVersion>3.26.3</assertjVersion> | |||
<asmVersion>9.7.1</asmVersion> | |||
<byteBuddyVersion>1.15.3</byteBuddyVersion> | |||
<cipherVersion>3.0.0</cipherVersion> | |||
<classWorldsVersion>2.8.0</classWorldsVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate line ?
gnodet
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove duplicate line, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
mvnenc
tool that is on par with Maven3 master password encryption functionality wise, but is really secure unlike Maven3 conterpart. On the other hand, is backward compatible if legacy config is setup.Implemented goals:
init
,encrypt
,decrypt
,diag
. Also provides one extra "master source" based on Maven infra Prompter: console master password prompt.Depends on codehaus-plexus/plexus-sec-dispatcher#75
https://asciinema.org/a/ZBXM9PMmdkkloLA8Vkq6cOwle
https://issues.apache.org/jira/browse/MNG-8285