Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8285] Implement mvnenc CLI tool #1793

Merged
merged 27 commits into from
Oct 14, 2024
Merged

[MNG-8285] Implement mvnenc CLI tool #1793

merged 27 commits into from
Oct 14, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Oct 11, 2024

Implements the mvnenc tool that is on par with Maven3 master password encryption functionality wise, but is really secure unlike Maven3 conterpart. On the other hand, is backward compatible if legacy config is setup.

Implemented goals: init, encrypt, decrypt, diag. Also provides one extra "master source" based on Maven infra Prompter: console master password prompt.

Depends on codehaus-plexus/plexus-sec-dispatcher#75

https://asciinema.org/a/ZBXM9PMmdkkloLA8Vkq6cOwle


https://issues.apache.org/jira/browse/MNG-8285

@cstamas cstamas requested a review from gnodet October 11, 2024 14:46
@cstamas cstamas self-assigned this Oct 11, 2024
We REQUIRE interactive for init wizard, and these params
made no sense. So let's drop them for now, will return if
needed.
* init goal obey "hidden" meta (so LEGACY cannot be set as def dispatcher)
* settings decrypter create WARN severity problems if legacy pw found
* session factory ALWAYS emits problems, unlike in mvn3 when these are logging ONLY in -X mode
@cstamas cstamas closed this Oct 14, 2024
@cstamas cstamas deleted the mvnenc branch October 14, 2024 11:37
@cstamas cstamas restored the mvnenc branch October 14, 2024 11:38
@cstamas cstamas reopened this Oct 14, 2024
@cstamas cstamas marked this pull request as ready for review October 14, 2024 11:44
@@ -167,7 +167,7 @@ under the License.
<assertjVersion>3.26.3</assertjVersion>
<asmVersion>9.7.1</asmVersion>
<byteBuddyVersion>1.15.3</byteBuddyVersion>
<cipherVersion>3.0.0</cipherVersion>
<classWorldsVersion>2.8.0</classWorldsVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line ?

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove duplicate line, otherwise LGTM

@cstamas cstamas merged commit f5e54ca into apache:master Oct 14, 2024
7 checks passed
@cstamas cstamas deleted the mvnenc branch October 14, 2024 19:57
@cstamas cstamas added this to the 4.0.0-beta-5 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants